stream: validate writevSync chunks before queuing#64300
Open
trivikr wants to merge 1 commit into
Open
Conversation
Ensure writevSync() validates every chunk before handing the batch to the push queue. Invalid chunks now throw ERR_INVALID_ARG_TYPE without leaving data readable from the failed write. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
jasnell
approved these changes
Jul 7, 2026
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
trivikr
added
the
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64299
stream/iternow validates allwritevSync()chunks before queueing abatch. Previously, invalid chunks such as
[1]could be queued first andthen throw from the queue’s byte-length accounting path, leaving invalid data
visible to the readable side.
This updates the shared chunk fast path to only skip conversion when every
entry is already a
Uint8Array, and adds regression coverage that verifieswritevSync([1])throwsERR_INVALID_ARG_TYPEwithout queueing data.Assisted-by: openai:gpt-5.5